Tweaked some naming but theres likely going to be the odd bit of name tweaking still.

I suggest to merge this change before the other, so we can experiment with this.

i will tweak and rebase this on main so it can be merged independent of other font scaling tweaks.

Rebased, removed the other font scaling stuff and tweaked based on feedback.

This now will not scale the font if the value is set to zero, which i have set as the default.

This is not what I meant :)

adjustFactor = 1.0f + (adjustFactor-1.0f) * m_resolutionFontSizeAdjustment * TheGlobalData->m_resolutionFontAdjustment; was fine, because if TheGlobalData->m_resolutionFontAdjustment is 0, then the adjust factor simply will be one: no resolution scaling, text has same size as with 800 x 600

* (1 + TheGlobalData->m_resolutionFontAdjustment) is misleading, because 1 becomes 2 (doubling).

This is not what I meant :)

adjustFactor = 1.0f + (adjustFactor-1.0f) * m_resolutionFontSizeAdjustment * TheGlobalData->m_resolutionFontAdjustment; was fine, because if TheGlobalData->m_resolutionFontAdjustment is 0, then the adjust factor simply will be one: no resolution scaling, text has same size as with 800 x 600

* (1 + TheGlobalData->m_resolutionFontAdjustment) is misleading, because 1 becomes 2 (doubling).

Yeah i thought you meant that zero would result in the extra user option not having any effect on the current scaling.
So the game essentially just scales like it normally would.

Also this is the game with just the raw Font sizes, so m_resolutionFontAdjustment at zero

Tweaked and pushed.

One more thought: If a user sets the scale to 1, then we would expect a linear scale. But instead it would "secretly" scale by 0.7 * 1. I wonder if we should do something about that.

One more thought: If a user sets the scale to 1, then we would expect a linear scale. But instead it would "secretly" scale by 0.7 * 1. I wonder if we should do something about that.

Should we override whatever m_resolutionFontSizeAdjustment is set to with the user set option? But take whatever m_resolutionFontSizeAdjustment is as the default?

Situation here ends up a bit like what the scroll Anchor PR is doing.
We consider the user option to be the source of truth and the ini value as the default.

Maybe start m_resolutionFontSizeAdjustment as -1 and if it less than 0 then we use Language.ini settings, otherwise user setting. Not sure.

So tweaked this now so by default, for this PR, the user based setting does not adjust the default from languages.ini

Tweaked based on some of the feedback.

Tweaked now so the GlobalLanguage reads from the options.ini and loads the value locally.

The options menu then reads from the options ini and sets the value in GlobalLanguage

will replicate to generals later if we think this is good to go now.

Tweaked and replicated to generals

Tweaked and pushed.

GUIEdit doesn't start anymore after this PR.

@Mauller Can you check please?

It opens and runs perfectly fine for me when building it locally.

So opening the build artifact, it's crashing when trying to retrieve the user path to the game options in global languages

This seems to only be a VC6 issue

Think i may have figured it out now, global languages is initialised before global data in guiedits init function.
just re-arranged to test.

Interesting that VS22 builds are immune to this if it starts working for VC6.